Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Migrate column-flex-child-with-overflow-scroll.html to WPT #22425

Merged
merged 1 commit into from Mar 24, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 24, 2020

This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html
to WPT directory. The test itself ensures the 'height' of flex children
with 'overflow: scroll' do not shrink (commonly by the size of the
scrollbar height).

Original CL: https://codereview.chromium.org/417153003

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753024}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html
to WPT directory. The test itself ensures the 'height' of flex children
with 'overflow: scroll' do not shrink (commonly by the size of the
scrollbar height).

Original CL: https://codereview.chromium.org/417153003

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#753024}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants