Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-8.10.1: rc1 -> final #83316

Merged
merged 2 commits into from Mar 25, 2020
Merged

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Mar 24, 2020

Motivation for this change

https://mail.haskell.org/pipermail/ghc-devs/2020-March/018729.html
https://mail.haskell.org/pipermail/ghc-devs/2020-March/018730.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
Copy link
Contributor Author

ggreif commented Mar 24, 2020

@GrahamcOfBorg build haskell.compiler.ghc8101

@ggreif
Copy link
Contributor Author

ggreif commented Mar 24, 2020

Reformatted. Now diff is

$ diff -u pkgs/development/compilers/ghc/8.8.3.nix pkgs/development/compilers/ghc/8.10.1.nix 
--- pkgs/development/compilers/ghc/8.8.3.nix	2020-03-02 15:30:57.684259857 +0100
+++ pkgs/development/compilers/ghc/8.10.1.nix	2020-03-24 22:50:46.645252287 +0100
@@ -88,12 +88,12 @@
 
 in
 stdenv.mkDerivation (rec {
-  version = "8.8.3";
+  version = "8.10.1";
   name = "${targetPrefix}ghc-${version}";
 
   src = fetchurl {
-    url = "https://downloads.haskell.org/ghc/${version}/ghc-${version}-src.tar.xz";
-    sha256 = "128g932i3wix6ic03v04nh5755vyjiidzri9iybwad72yfmc1p70";
+    url = "https://downloads.haskell.org/ghc/8.10.1/ghc-${version}-src.tar.xz";
+    sha256 = "1xgdl6ig5jzli3bg054vfryfkg0y6wggf68g66c32sr67bw0ffsf";
   };
 
   enableParallelBuilding = true;

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.compiler.ghc8101

@cdepillabout
Copy link
Member

LGTM, thanks for always being on top of these updates!

@cdepillabout cdepillabout merged commit 6da5ef0 into NixOS:haskell-updates Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants