Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qiskit-ibmq-provider: init at 0.5.0 #83320

Merged
merged 3 commits into from Mar 26, 2020
Merged

pythonPackages.qiskit-ibmq-provider: init at 0.5.0 #83320

merged 3 commits into from Mar 26, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Qiskit Provider for accessing the quantum devices and simulators at IBMQ.

Requirement of qiskit package. Update qiskit according to new upstream package structure (collection of subpackages). This is broken out of #78772.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
pythonPackages.qiskit-ibmq-provider: init at 0.4.5
4ce7413 
Qiskit Provider for accessing the quantum devices and simulators at IBMQ.

Requirement of qiskit package.
@drewrisinger
Copy link
Contributor Author

This version is out-of-date. Most recent is 0.5.0. Will post upgrade to that.

@ofborg ofborg bot requested a review from thoughtpolice March 25, 2020 00:24
@drewrisinger
Copy link
Contributor Author

Will remove arrow commit on approval of #83370

@drewrisinger drewrisinger mentioned this pull request Mar 25, 2020
Closed
10 tasks
@drewrisinger drewrisinger changed the title pythonPackages.qiskit-ibmq-provider: init at 0.4.5 pythonPackages.qiskit-ibmq-provider: init at 0.5.0 Mar 25, 2020
jonringer
jonringer approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

2 package marked as broken and skipped:
bonfire python37Packages.mailman-web

1 package failed to build:
topydo

24 package built:
aws-sam-cli backblaze-b2 buku cookiecutter deja-dup duplicity duply mailman-web python27Packages.arrow python27Packages.cookiecutter python27Packages.jinja2_time rainbowstream python27Packages.stravalib python37Packages.arrow python37Packages.django-q python37Packages.hyperkitty python37Packages.ics python37Packages.jinja2_time python37Packages.mesa python37Packages.qiskit-ibmq-provider python37Packages.rainbowstream python37Packages.stravalib rapid-photo-downloader watson

@jonringer
Copy link
Contributor

failure broken on master

@jonringer jonringer merged commit 1dc44cc into NixOS:master Mar 26, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-qiskit-ibmq-provider branch March 26, 2020 19:44
This was referenced Mar 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer