Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/quorum: init #83309

Merged
merged 1 commit into from Mar 28, 2020
Merged

nixos/quorum: init #83309

merged 1 commit into from Mar 28, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Mar 24, 2020

Motivation for this change

Service for the quorum private blockchain.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from infinisil as a code owner March 24, 2020 18:39
@mmahut
Copy link
Member Author

mmahut commented Mar 24, 2020

@GrahamcOfBorg test quorum

mmilata
mmilata reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, added bunch of nitpicks.

nixos/modules/services/networking/quorum.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/quorum.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/quorum.nix Outdated Show resolved Hide resolved
@mmahut mmahut force-pushed the quorum branch 2 times, most recently from e65caf0 to c6f1b9e Compare March 26, 2020 15:06
@mmahut
Copy link
Member Author

mmahut commented Mar 26, 2020

Rebased with ws support.

@mmahut
Copy link
Member Author

mmahut commented Mar 26, 2020

@GrahamcOfBorg test quorum

sorki
sorki approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nixos/modules/services/networking/quorum.nix Show resolved Hide resolved
nixos/modules/services/networking/quorum.nix Outdated Show resolved Hide resolved
nixos/tests/quorum.nix Show resolved Hide resolved
@mmahut
Copy link
Member Author

mmahut commented Mar 27, 2020

@GrahamcOfBorg test quorum

@mmahut mmahut merged commit 42d03aa into NixOS:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata left review comments

@sorki sorki sorki approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmahut @mmilata @sorki