Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.flask-appbuilder: 2.1.6 -> 2.3.0 #83315

Merged
merged 1 commit into from Mar 25, 2020
Merged

pythonPackages.flask-appbuilder: 2.1.6 -> 2.3.0 #83315

merged 1 commit into from Mar 25, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Mar 24, 2020 •
edited

Motivation for this change

While upgrading a separate package, saw pythonPackages.flask-appbuilder had a new version.
Waiting on #83314 to pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc March 24, 2020 21:20
@drewrisinger drewrisinger mentioned this pull request Mar 25, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

failure broken on master

https://github.com/NixOS/nixpkgs/pull/83315
1 package failed to build:
python38Packages.apache-airflow

3 package built:
apache-airflow python37Packages.flask-appbuilder python38Packages.flask-appbuilder

@jonringer jonringer merged commit 0005b13 into NixOS:master Mar 25, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-flask-appbuilder-bump branch March 25, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer