Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.compiler.ghc8101: update #83404

Closed
wants to merge 1 commit into from
Closed

haskell.compiler.ghc8101: update #83404

wants to merge 1 commit into from

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar
Copy link
Member Author

I'm building this locally, it's going to take a while on my laptop.

@vaibhavsagar
Copy link
Member Author

I didn't look closely enough, this has already been taken care of in 56c6901.

@vaibhavsagar vaibhavsagar deleted the ghc8101 branch March 26, 2020 03:27
@ofborg ofborg bot requested review from peti and kosmikus March 26, 2020 03:31
@vaibhavsagar vaibhavsagar restored the ghc8101 branch March 26, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@peti peti Awaiting requested review from peti

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vaibhavsagar