Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo: switch download from FTP to HTTPS #83407

Merged
merged 1 commit into from Mar 26, 2020
Merged

sudo: switch download from FTP to HTTPS #83407

merged 1 commit into from Mar 26, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 26, 2020

Many firewalls don't allow FTP traffic through; HTTPS should be preferred when
possible for both availability and performance.

Sending this PR to staging just to avoid unnecessary merge conflicts with #83394
when maintainers do the master -> staging merge.

This passes nix-build -A sudo.src --check and causes no rebuilds.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
sudo: switch download from FTP to HTTPS
f389acf 
Many firewalls don't allow FTP traffic through; HTTPS should be preferred when
possible for both availability and performance.
@bhipple bhipple requested a review from nh2 March 26, 2020 04:10
@FRidh FRidh merged commit e49a624 into NixOS:staging Mar 26, 2020
@vcunat
Copy link
Member

vcunat commented Mar 26, 2020

For reference, such changes cause no rebuilds, so they certainly don't need to go through staging.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 26, 2020

Yeah, under normal circumstances I'd send it straight to master, but since this is not an urgent change and since there are sudo changes on the staging branch that'd cause git merge conflicts when you eventually hit master, I sent it to staging to save you and @FRidh some effort. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @vcunat @FRidh