New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/pixiecore: init #83406
nixos/pixiecore: init #83406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM. Always happy to see Pixiecore in the wild :)
bcdf812
to
be01b2b
Compare
Thank you very much @danderson and @samueldr . I made all the changes. |
It would be also great if you could update the wiki after that. |
Thanks for the review @Profpatsch . Is it OK like that or should I use EDIT: I also made kernel = "https://boot.netboot.xyz/ipxe/netboot.xyz.lkrn";
Yep. I also have another PR in the work that might be nice. |
I made the changes. Thanks. I'll squash the commits at the end. Or I think you guys can do it automatically while merging. |
What's that |
Thanks. I made the change and squashed the commits. |
I made the changes. Thanks. Should |
It is not needed otherwise. So it sounds like a good idea. |
are both low low ports (67 and 69) used by dhcp? |
Port 69 is TFTP. Pixiecore does a fairly elaborate chainloading operation (described in https://github.com/danderson/netboot/blob/master/pixiecore/README.booting.md) to ensure that it works with the widest possible variety of weird and broken firmwares. TL;DR: a PXE-booting client hits port 67 for DHCP, then port 4011 (BINL, an MS proprietary fork of PXE but that's a de-facto standard), then port 69 (TFTP to download iPXE with HTTP support), then the HTTP port (to finally download boot instructions, kernel+initrd, and finish the netboot). |
Co-authored-by: raunovv <rauno@oyenetwork.com> Co-Authored-By: Jörg Thalheim <Mic92@users.noreply.github.com>
I made the change. Is it OK like this? nixpkgs/nixos/modules/services/networking/pixiecore.nix Lines 111 to 114 in b1ee662
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side, if @Mic92 is okay with it.
Motivation for this change
This should only be merged after #83373 . You can use that PR to review the package part. This is one is for the module.
This is a rebase of #62113 (the module part).
I also added support for the "api" mode and added openFirewall and extraArguments options.
I tried to address all the reviews from the old abandoned PR.
The module was requested in #49740
@Lassulus @aanderse @Ekleog
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)