Build MELPA package sets without null packages #83378
Merged
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrepues
force-pushed
the
build-melpa-stable-with-no-null-pkgs
branch
from
293ad70 to
ce3028e
Compare
ofborg
bot
added
10.rebuild-darwin: 0
The current algorithm creates attributes with null values for packages with no source in a variant of MELPA. Though will satify dependencies they produce no files, and though a build that transitively depends on one them will be successful, Emacs won't find them and any code depending on them won't work. The solution with minimal code change would have been filtering the list of results from melpaDerivation by comparing the value against null, but that leads to an infinite recursion. This commit also moves legacy renames from the shared to the unstable set, as the corresponding null value elements won't exist in the stable set anymore. The test used for the problem was: $ nix-build --show-trace ./default.nix -A emacs26Packages.melpaStablePackages.findr error: expression does not evaluate to a derivation (or a set or list of those) The expected output, obtained with this commit is: $ nix-build --show-trace ./default.nix -A emacs26Packages.melpaStablePackages.findr error: attribute 'findr' in selection path 'emacs26Packages.melpaStablePackages.findr' not found
afrepues
force-pushed
the
build-melpa-stable-with-no-null-pkgs
branch
from
a2f112e to
b2c8626
Compare
afrepues
changed the title
|
@GrahamcOfBorg build emacs26Packages.melpaStablePackages.findr |
|
@adisbladis do you have time to review this? |
|
@adisbladis this affects 20.03 as well, and this branch can be cleanly merged into |
adisbladis
added
the
9.needs: port to stable
|
@afrepues Could you cherry-pick this on top of 20.03 and send a separate PR? (Use |
|
@adisbladis backport to 20.03 in !86213 |
10 tasks
13 tasks
jian-lin
added a commit
to linj-fork/nixpkgs
that referenced
this pull request
Sep 14, 2024
This is a follow up of [1]. With that PR applied, packages will not be null. [1]: NixOS#83378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current algorithm creates attributes with null values for packages
with no source in a variant of MELPA. Though will satify dependencies
they produce no files, and though a build that transitively depends on
one them will be successful, Emacs won't find them and any code
depending on them won't work.
The solution with minimal code change would have been filtering the
list of results from melpaDerivation by comparing the value against
null, but that leads to an infinite recursion.
This commit also moves legacy renames from the shared to the unstable
set, as the corresponding null value elements won't exist in the
stable set anymore.
The test used for the problem was:
The expected output, obtained with this commit is:
Merging into other branches
This can be cleanly merged into release-20.03, merging into an older branch will need to be done by cherry picking.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)