goimapnotify: init at 2.0 #83385
goimapnotify: init at 2.0 #83385
Conversation
There was a problem hiding this comment.
Thanks for your first PR :) 🚀
Please squash your commits into one commit goimapnotify: init at 2.0.
The binary builds and runs fine for me. However, I don't know enough about go packaging to review this. @marsam, @doronbehar, what do you think?
There was a problem hiding this comment.
Besides the comment I left, it seems to build and run but I don't get any output when I run:
./result-bin/bin/goimapnotify -conf ~/.config/goimapnotify.conf -list
No idea why's that. Also, the project seems somewhat unmaintained, at least for 5 months or so:
https://gitlab.com/shackra/goimapnotify/-/issues/4 && https://gitlab.com/shackra/goimapnotify/activity
|
@doronbehar re empty output: not sure what that's about. could maybe tell you more if I saw what's in your goimapnotify.conf? re project maintenance: not sure what's going on there either, I'm not personally involved in the project beyond packaging it here. |
There was a problem hiding this comment.
@wohanley I've managed to make it work after changing some variables in my config, at least for -list. I wouldn't say this project has the best UX regarding error handling. It also printed my boxes in a somewhat malformed format, but I guess that shouldn't hold it from getting into our package collection if you'd be willing to maintain it.
|
@doronbehar yep, i'm happy to take care of it. thanks! |
|
Is there something else I need to do here? Sorry, this process is new to me. |
|
LGTM, sorry for the delay |
|
Thanks! |
Motivation for this change
goimapnotify is more reliable in my experience than the alternative currently available on nixpkgs, node-imapnotify.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)