Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechatScripts.wee-slack: 2.4.0 -> 2.5.0 #83347

Closed
wants to merge 1 commit into from
Closed

weechatScripts.wee-slack: 2.4.0 -> 2.5.0 #83347

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title weechatScripts.wee-slack: 2.4.0 -> v2.5.0 weechatScripts.wee-slack: 2.4.0 -> 2.5.0 Mar 25, 2020
@lsix
Copy link
Member

lsix commented Mar 25, 2020

Looks like this PR duplicates #83339

Could you check the other one (that brings some modifications) and select the one which is most adequate?

@Mic92
Copy link
Member Author

Mic92 commented Mar 25, 2020

The other one is better.

@Mic92 Mic92 closed this Mar 25, 2020
@Mic92 Mic92 deleted the wee-slack branch March 25, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @lsix