Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo edit: 0.5.0 -> 0.6.0 #83070

Merged
merged 1 commit into from Mar 26, 2020
Merged

cargo edit: 0.5.0 -> 0.6.0 #83070

merged 1 commit into from Mar 26, 2020

Conversation

killercup
Copy link
Member

Motivation for this change

New release: https://github.com/killercup/cargo-edit/releases/tag/v0.6.0

Additional changes:

  • Add myself as maintainer
  • Some workspace test failed with a cargo config error, I didn't investigate too much. This was a problem in earlier versions, too.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jb55, Gerschtli and Br1ght0ne March 21, 2020 12:25
bhipple
bhipple approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commits should be squashed up prior to merge tho!

pkgs/tools/package-management/cargo-edit/default.nix Outdated Show resolved Hide resolved
@killercup
cargo edit: 0.5.0 -> 0.6.0
84ac1d5 
- Update to new version
- Add myself as maintainer
- Some workspace test failed with a cargo config error, I didn't
  investigate too much.
- Add Apache 2.0 license
@killercup
Copy link
Member Author

ping @bhipple should be good to merge

@bhipple
Copy link
Contributor

bhipple commented Mar 26, 2020 •
edited 

[4 built, 0.0 MiB DL]
1 package built:
cargo-edit

@bhipple bhipple merged commit 7f62b75 into NixOS:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@jb55 jb55 Awaiting requested review from jb55

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@killercup @bhipple