De-flake image-loading-subpixel-clip.html #22444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 25, 2020
If the image is in cache, then the onload handler could happen synchronously before the script had a time to add the handler. The fix is to set the src after the onload handler has been registered. Change-Id: I8586119c5b36f033f36a594cd021230cb8a2bb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119634 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753318}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2119634
branch
from
74d1c61
to
cfa1441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the image is in cache, then the onload handler could happen
synchronously before the script had a time to add the handler.
The fix is to set the src after the onload handler has been registered.
Change-Id: I8586119c5b36f033f36a594cd021230cb8a2bb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119634
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753318}