[css-flexbox] Migrate content-height-with-scrollbars.html to WPT #22445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 25, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2120853
branch
2 times, most recently
from
14bcfda
to
8a3dea7
Compare
Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753356}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2120853
branch
from
8a3dea7
to
5006f06
Compare
|
This WPT test mistakenly assumes/expects that scrollbars occupy space -- but they don't, if they're overlay-style. So the test fails in both Firefox and Chrome on Android (at least). Here are links that you can use to see this yourself: See https://bugzilla.mozilla.org/show_bug.cgi?id=1626212#c2 for more details/analysis. Not sure what the best course of action is here (backing out vs. leaving it in and annotating it as failing on platforms with overlay scrollbars)... Just posting here as an FYI for now. |
|
( CC @cbiesinger @davidsgrogan ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667
BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org
Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753356}