Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] protonvpn-cli-ng: 2.2.0 -> 2.2.2 #83330

Merged
merged 1 commit into from Mar 26, 2020
Merged

[20.03] protonvpn-cli-ng: 2.2.0 -> 2.2.2 #83330

merged 1 commit into from Mar 26, 2020

Conversation

JeffLabonte
Copy link
Contributor

Some changes were made after final review of the package. There was a
missing runtime dependency that was discovered after merge of the
backport

(cherry picked from commit 9fe4a63)
Reason: The dependency can make the package work or not

Motivation for this change

Make sure the package works for everybody

Things done

Backport from PR #81735

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
protonvpn-cli-ng: 2.2.0 -> 2.2.2
b02da56 
Some changes were made after final review of the package. There was a
missing runtime dependency that was discovered after merge of the
backport

(cherry picked from commit 9fe4a63)
Reason: The dependency can make the package work or not
@JeffLabonte JeffLabonte changed the title protonvpn-cli-ng: 2.2.0 -> 2.2.2 [20.03] protonvpn-cli-ng: 2.2.0 -> 2.2.2 Mar 25, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pr-approved-needs-merging-protonvpn-cli-ng/6406/4

@ofborg ofborg bot requested a review from jtcoolen March 25, 2020 01:23
@bhipple bhipple merged commit 34e93f4 into NixOS:release-20.03 Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcoolen jtcoolen jtcoolen approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @nixos-discourse @jtcoolen @bhipple