Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloop: add blp linking to bloop #83361

Closed
wants to merge 1 commit into from
Closed

bloop: add blp linking to bloop #83361

wants to merge 1 commit into from

Conversation

karolchmist
Copy link
Member

Motivation for this change

When trying to use Bloop with BSP in Intellij IDEA, I was getting an error:

Cannot run program "/nix/store/iskjxr3qbdyq72dzh7kmxjvcxy7zd1lf-user-environment/bin/blp" (in directory "/home/karol/workspace/yields/foundation/registry"): error=2, No such file or directory

I'm not sure why blp is called, but I didn't find any issue in Intellij. So I assume it's something NixOS related.

My naïve solution was to add link from bloop to bsp, as in this PR, and it worked flawlessly. I'm not sure at all if it's a good solution, but I've been using it for a couple of days now and it just works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Pinging @Tomahna :)

@Tomahna
Copy link
Contributor

Tomahna commented Mar 25, 2020 •
edited

So the weird thing here is that bloop, when using the default install method, does not seem to create a blp executable file.

❯ tree .bloop ~
.bloop
├── bash
│   └── bloop
├── bloop
├── blp-coursier
├── blp-server
├── fish
│   └── bloop.fish
├── systemd
│   └── bloop.service
├── xdg
│   ├── bloop.desktop
│   └── bloop.png
└── zsh
└── _bloop

It is probably not a big deal add a symlink. I'll just look try to look into where IntelliJ gets this path first.

@Tomahna
Copy link
Contributor

Tomahna commented Mar 31, 2020 •
edited

Sorry for the delay. I've not been able to reproduce your problem. What version of IntelliJ are you running ?

@karolchmist
Copy link
Member Author

Sorry for even bigger delay :)

I just installed IDEA 2020.1 and it works now fine whithout this PR. So I'm closing it.

Thx @Tomahna anyway!

BTW, the support for BSP in the new IDEA is seemingly much better now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karolchmist @Tomahna