Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/boinc: simplify setup of boinc service #83362

Merged
merged 2 commits into from Apr 14, 2020
Merged

nixos/boinc: simplify setup of boinc service #83362

merged 2 commits into from Apr 14, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Mar 25, 2020

Motivation for this change

Improve the out of the box experience for boinc.

The two improvements are:

  1. Log to journal instead of a dedicated log file. This is less confusing in my opinion as running journalctl -u boinc now shows the logs.
  2. Create a boinc group to allow users easier access to the rpc secret located in the data dir.
    This allows easy access by running boincmgr -d /var/lib/boinc for all users in the boinc group.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
nixos/boinc: log to journal instead of log file
bb549ca
@bachp
nixos/boinc: create boinc group
2e5835c 
This allows users that are members of the boinc group
to interact with the boinc service by running:

boincmgr -d /var/lib/boinc
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/fight-covid-19-with-folding-home-and-nixos/6202/42

@bachp
Copy link
Member Author

bachp commented Mar 31, 2020

@kierdavis please take a look

kierdavis
kierdavis approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@kierdavis kierdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bachp
Copy link
Member Author

bachp commented Apr 14, 2020

@matthewbauer please take a look, can this be merged?

@matthewbauer matthewbauer merged commit 57e20c5 into NixOS:master Apr 14, 2020
@bachp bachp deleted the boinc branch April 14, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kierdavis kierdavis kierdavis approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachp @nixos-discourse @kierdavis @matthewbauer