Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-manager: sync default.nix with upstream #83360

Closed
wants to merge 2 commits into from
Closed

home-manager: sync default.nix with upstream #83360

wants to merge 2 commits into from

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 25, 2020 •
edited

Motivation for this change

Completions were missing and platforms were overly restrictive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau mentioned this pull request Mar 25, 2020
Closed
@ofborg ofborg bot requested a review from rycee March 25, 2020 14:20
@rycee
Copy link
Member

rycee commented Mar 25, 2020

Nice, rebased to master in d5c0289.

@rycee rycee closed this Mar 25, 2020
@timokau timokau deleted the home-manager-completions branch March 25, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @rycee