Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] Backport rls: add llvm to buildInputs #80651

Merged
merged 1 commit into from Feb 20, 2020
Merged

[20.03] Backport rls: add llvm to buildInputs #80651

merged 1 commit into from Feb 20, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 20, 2020

The Hydra build [1] was failing because it was unable to link LLVM-9.
Additionally, quote the homepage URL for compliance with RFC 45.

[1] https://hydra.nixos.org/build/112823631/nixlog/2

(cherry picked from commit 2edec09)

Part of ZHF: #80379.
Original PR: #80602.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
rls: add llvm to buildInputs
b6f86ae 
The Hydra build [1] was failing because it was unable to link `LLVM-9`.
Additionally, quote the homepage URL for compliance with RFC 45.

[1] https://hydra.nixos.org/build/112823631/nixlog/2

(cherry picked from commit 2edec09)
@ofborg ofborg bot added the 6.topic: rust label Feb 20, 2020
@ofborg ofborg bot requested a review from symphorien February 20, 2020 16:49
jonringer
jonringer approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[2 built, 8 copied (3.4 MiB), 0.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80651
1 package built:
rls

@jonringer jonringer merged commit 970694c into NixOS:release-20.03 Feb 20, 2020
@cole-h cole-h deleted the release-20.03 branch February 20, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@symphorien symphorien Awaiting requested review from symphorien

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @jonringer