Update to current nixpkgs-unstable #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
force-pushed
the
update-nixpkgs
branch
from
81c9cf0
to
13d1af0
Compare
|
I am still trying to figure out what it takes to make the PHP stuff work again.. Right now it is just spewing out cryptic error messages about |
This required the introduction of an overlay file since ofBorg still requires openssl 1.0.2. Updating to newer version of openssl also requires updating the amqp library which requires some more involved changes. The php code is only updated to php 7.2 and not 7.3 (the default in nixpkgs) since there seem to been a few syntax changes that aren't yet compatible with composer2nix. In previous versions of the rust infrastructure within nixpkgs we would have been able to override all crates during the invocation of the target crate. That `override` feature was removed as it caused a huge eval overhead for larger projects. We did end up with (n^2) instantiations of dependencies since they were being overriden on every invocation of every dependency on every level further down the chain. The current understanding is that the build tooling that each project is using (e.g. crate2nix, crate2nix, …) that is driving the actual build could easily reintroduce that feature without the overhead. pin to php72
andir
force-pushed
the
update-nixpkgs
branch
from
13d1af0
to
41687fe
Compare
|
The default php version of unstable is 7.3 which did break composer2nix. For now we can probably just stick with 7.2. |
andir
force-pushed
the
update-nixpkgs
branch
from
0b3f891
to
e54b781
Compare
andir
force-pushed
the
update-nixpkgs
branch
from
e54b781
to
e3e32bc
Compare
|
Ok, CI finally passed. It looks good. Was a bit more involved due to the rust version upgrades and the corresponding linting fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required the introduction of an overlay file since ofBorg still
requires openssl 1.0.2. Updating to newer version of openssl also
requires updating the amqp library which requires some more involved
changes.
The php code is only updated to php 7.2 and not 7.3 (the default in
nixpkgs) since there seem to been a few syntax changes that aren't yet
compatible with composer2nix.
In previous versions of the rust infrastructure within nixpkgs we would
have been able to override all crates during the invocation of the
target crate. That
overridefeature was removed as it caused a hugeeval overhead for larger projects. We did end up with (n^2)
instantiations of dependencies since they were being overridden on every
invocation of every dependency on every level further down the chain.
The current understanding is that the build tooling that each project is
using (e.g. crate2nix, crate2nix, …) that is driving the actual build
could easily reintroduce that feature without the overhead.