Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rainloop: 1.13.0 -> 1.14.0 #80668

Closed
wants to merge 1 commit into from
Closed

rainloop: 1.13.0 -> 1.14.0 #80668

wants to merge 1 commit into from

Conversation

haskelious
Copy link
Contributor

  • update version
  • change mechanism to set the data folder outside the nix store
Motivation for this change

Update rainloop to latest available version, and also fix a problem on NixOS where the application would not work by simply creating a symlink for the 'data' folder, as rainloop will complain the data directory is not writable. The better way to set a data folder outside the rainloop folder is by creating a short include.php that is used as an override to data location.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@haskelious
rainloop: 1.13.0 -> 1.14.0
f8fdb71 
- update version
- change mechanism to set the data folder outside the nix store
@haskelious haskelious requested a review from dasJ February 20, 2020 21:43
@haskelious haskelious closed this Feb 21, 2020
@dasJ
Copy link
Member

dasJ commented Feb 21, 2020

Why did you close it? It looked good

@haskelious
Copy link
Contributor Author

It is not ready to merge. There seem to be issues with the change. I need to check & confirm. I will resubmit once ready.

@haskelious haskelious deleted the fix/rainloop-update branch February 23, 2020 20:25
@haskelious
Copy link
Contributor Author

New pull request to replace this one found at #80910
Sorry I did not know how I could repurpose this same pull request, so had to request a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haskelious @dasJ @Janik-Haag