Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webdis: init at 0.1.9 #80669

Merged
merged 1 commit into from Mar 16, 2020
Merged

webdis: init at 0.1.9 #80669

merged 1 commit into from Mar 16, 2020

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Feb 20, 2020

Motivation for this change

Having a thin HTTP abstraction layer for Redis

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wucke13 @doronbehar @marsam
webdis: init at 0.1.9
a08a416 
Co-Authored-By: Doron Behar <doron.behar@gmail.com>
doronbehar
doronbehar reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that all LGTM.

pkgs/development/tools/database/webdis/default.nix Outdated Show resolved Hide resolved
@wucke13
Copy link
Contributor Author

wucke13 commented Feb 21, 2020

@doronbehar Thank you for the review & the suggestion!
@GrahamcOfBorg build webdis

@wucke13 wucke13 changed the title webdis: init at 0.1.7 webdis: init at 0.1.9 Mar 13, 2020
@wucke13
Copy link
Contributor Author

wucke13 commented Mar 13, 2020

@GrahamcOfBorg build webdis

@wucke13
Copy link
Contributor Author

wucke13 commented Mar 14, 2020

@marsam ping 😈

@marsam
Copy link
Contributor

marsam commented Mar 16, 2020

Thanks, looks like a useful package.
I've made minor changes, I hope you don't mind.

@marsam marsam merged commit 0bb72bb into NixOS:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wucke13 @marsam @doronbehar