Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euler #2475

Merged
merged 7 commits into from
Feb 22, 2020
Merged

Euler #2475

merged 7 commits into from
Feb 22, 2020

Conversation

eggrobin
Copy link
Member

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -98,7 +101,9 @@ Status PileUp::DeformAndAdvanceTime(Instant const& t) {
absl::MutexLock l(lock_.get());
Status status;
if (psychohistory_->back().time < t) {
DeformPileUpIfNeeded();
angular_momentum_ += intrinsic_torque_ * (t - psychohistory_->back().time) +
angular_momentum_change_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this computation to the beginning of DeformPileUpIfNeeded? It's odd that it's floating here for no good reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not make sense.

@@ -145,16 +156,16 @@ class PileUp {
not_null<Ephemeris<Barycentric>*> ephemeris,
std::function<void()> deletion_callback);

void MakeEulerSolver(InertiaTensor<NonRotatingPileUp> const& inertia_tensor,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this function.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Feb 21, 2020
@pleroy pleroy merged commit 8dca142 into mockingbirdnest:frobenioid Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants