Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] weechat: 2.6 -> 2.7.1 #80675

Merged
merged 2 commits into from Feb 20, 2020
Merged

[19.09] weechat: 2.6 -> 2.7.1 #80675

merged 2 commits into from Feb 20, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 20, 2020 •
edited

Release notes:

irc: fix crash when receiving a malformed message 352 (who)
irc: fix crash when a new message 005 is received with longer nick prefixes
irc: fix crash when receiving a malformed message 324 (channel mode) (CVE-2020-8955)
(cherry picked from commit 2d77fc3)

backport of #80672

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title weechat: 2.7 -> 2.7.1 [19.09] weechat: 2.7 -> 2.7.1 Feb 20, 2020
@mweinelt mweinelt changed the title [19.09] weechat: 2.7 -> 2.7.1 [19.09] weechat: 2.6 -> 2.7.1 Feb 20, 2020
@mweinelt mweinelt mentioned this pull request Feb 20, 2020
Merged
10 tasks
@mweinelt
Copy link
Member Author

I didn't test this yet.

@andir
Copy link
Member

andir commented Feb 20, 2020 

-- Looking for scm_install_gmp_memory_functions - found
-- Could NOT find V8 (missing:  V8_LIBRARY V8_INCLUDE_DIR)
CMake Error at src/plugins/CMakeLists.txt:152 (message):
  V8 (javascript) not found


-- Checking for one of the modules 'php7'
CMake Warning at cmake/FindPHP.cmake:59 (message):
  Could not find libphp7.  Ensure PHP >=7.0.0 development libraries are
  installed and compiled with `--enable-embed`.  Ensure `php-config` is in
  `PATH`.  You may set `-DCMAKE_LIBRARY_PATH=...` to the directory containing
  libphp7.
Call Stack (most recent call first):
  src/plugins/CMakeLists.txt:157 (find_package)


CMake Error at src/plugins/CMakeLists.txt:161 (message):
  Php not found


-- Looking for aspell_version_string
-- Looking for aspell_version_string - not found
-- Checking for one of the modules 'ncursesw'
-- Looking for include file ncursesw/ncurses.h
-- Looking for include file ncursesw/ncurses.h - found
-- Configuring incomplete, errors occurred!
See also "/build/weechat-2.7.1/build/CMakeFiles/CMakeOutput.log".
See also "/build/weechat-2.7.1/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/qp1xbcb1ahl9b4nxc2s8wmx4km79zj74-weechat-2.7.1.drv' failed with exit code 1
cannot build derivation '/nix/store/48bl7svi4alqz9jkfmpjh13mvmqrms1v-weechat-bin-env-2.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/48bl7svi4alqz9jkfmpjh13mvmqrms1v-weechat-bin-env-2.7.1.drv' failed

It fails to compile :/

@mweinelt
weechat: 2.6 -> 2.7
4bbadcf 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html

(cherry picked from commit d1cb8bf)
@mweinelt
weechat: 2.7 -> 2.7.1
10babe3 
Release notes:

irc: fix crash when receiving a malformed message 352 (who)
irc: fix crash when a new message 005 is received with longer nick prefixes
irc: fix crash when receiving a malformed message 324 (channel mode) (CVE-2020-8955)
(cherry picked from commit 2d77fc3)
@mweinelt
Copy link
Member Author

mweinelt commented Feb 20, 2020 •
edited

Yep, backported the 2.6->2.7 change as well. Works for me now.

@andir
Copy link
Member

andir commented Feb 20, 2020

I have this on my weechat instance now. So far nothing has exploded.

@andir andir merged commit b23f211 into NixOS:release-19.09 Feb 20, 2020
@mweinelt mweinelt deleted the pr/19.09/weechat/2.7.1 branch February 20, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

@lsix lsix lsix approved these changes

@lheckemann lheckemann Awaiting requested review from lheckemann

@lovek323 lovek323 Awaiting requested review from lovek323

@the-kenny the-kenny Awaiting requested review from the-kenny

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @andir @lsix