-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Euler #2475
Euler #2475
Conversation
rigid_motion.WriteToMessage(&( | ||
(*message->mutable_actual_part_rigid_motion())[part->part_id()])); | ||
rigid_motion.WriteToMessage( | ||
&((*message->mutable_actual_part_rigid_motion())[part->part_id()])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many spurious formatting changes. Please undo.
@@ -98,7 +101,9 @@ Status PileUp::DeformAndAdvanceTime(Instant const& t) { | |||
absl::MutexLock l(lock_.get()); | |||
Status status; | |||
if (psychohistory_->back().time < t) { | |||
DeformPileUpIfNeeded(); | |||
angular_momentum_ += intrinsic_torque_ * (t - psychohistory_->back().time) + | |||
angular_momentum_change_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move this computation to the beginning of DeformPileUpIfNeeded
? It's odd that it's floating here for no good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does not make sense.
No description provided.