Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kodi: fix build #80700

Merged
merged 1 commit into from Feb 22, 2020
Merged

kodi: fix build #80700

merged 1 commit into from Feb 22, 2020

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

ZHF: #80379

@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build kodi-wayland kodi

@aanderse
Copy link
Member

I haven't tested this yet, but I ran into this issue when trying to update to 20.03 and this was the solution I found as well. Seeing as this is a current blocker for me upgrading to 20.03 I'm a fan of merging this 👍

@worldofpeace worldofpeace merged commit 7cf8364 into NixOS:master Feb 22, 2020
@worldofpeace
Copy link
Contributor

@xfix Could you open a backport PR?

@KamilaBorowska KamilaBorowska mentioned this pull request Feb 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@edwtjo edwtjo Awaiting requested review from edwtjo

@domenkozar domenkozar Awaiting requested review from domenkozar

@titanous titanous Awaiting requested review from titanous

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @aanderse @worldofpeace @cole-h