Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r20.03] kdepim-runtime: Remove obsolete patch to fix compilation #80661

Merged
merged 1 commit into from Feb 21, 2020
Merged

[r20.03] kdepim-runtime: Remove obsolete patch to fix compilation #80661

merged 1 commit into from Feb 21, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 20, 2020 •
edited

The facebook plugin is currently disabled by upstream.

(cherry picked from commit f2c564b)

Motivation for this change

ZHF: #80379, original PR: #79908

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bkchr @KamilaBorowska
kdepim-runtime: Remove obsolete patch to fix compilation
205ab7e 
The facebook plugin is currently disabled by upstream.

(cherry picked from commit f2c564b)
@ofborg ofborg bot requested a review from vandenoever February 20, 2020 19:29
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build kdeApplications.kdepim-runtime

@infinisil infinisil merged commit 87d6296 into NixOS:release-20.03 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@vandenoever vandenoever Awaiting requested review from vandenoever

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KamilaBorowska @worldofpeace @infinisil @bkchr