Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.qiskit-aer: init at 0.4.1 #80662

Merged
merged 1 commit into from Mar 27, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Update qiskit according to new upstream package structure (collection of subpackages). This is broken out of #78772. Would like to get it into 20.03 if at all possible. Has out-of-tree dependencies: qiskit-terra #80464 and cvxpy (#78898). I will rebase & remove commits when each is approved.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit-aer python38Packages.qiskit-aer

@drewrisinger drewrisinger changed the title pythonPackages.qiskit-aer: init at 0.3.4 pythonPackages.qiskit-aer: init at 0.4.1 Mar 24, 2020
@drewrisinger
Copy link
Contributor Author

@jonringer, all dependencies of this have been resolved. Updated to latest version. Builds cleanly, minus python3.8 build due to scikit-build failure #83305.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/80662
1 package failed to build:
python38Packages.qiskit-aer

1 package built:
python37Packages.qiskit-aer

pkgs/development/python-modules/qiskit-aer/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor Author

ack. resolved, rebased to compress commits, tested, & pushed.

@drewrisinger
Copy link
Contributor Author

@jonringer good to merge per your review. rebased to fix conflict b/w this and #83320 in python-packages.nix.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/qiskit-aer/default.nix Outdated Show resolved Hide resolved
Qiskit Aer - High performance simulators for Qiskit.

This commit follows the new Qiskit scheme of breaking one large package
into smaller packages (terra, aer, etc), and then having a single
meta-package "qiskit" that comprises them.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Mar 27, 2020

Suggestion works & builds.
@GrahamcOfBorg build python37Packages.qiskit-aer
@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

ofborg sometimes has delay in eval'ing due to long queues. I'm building it now

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg eval.
Forgot builds fail due to cvxpy dependency on unfree mkl

@drewrisinger
Copy link
Contributor Author

built locally.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failure from python38Packages.scikit-build failing to build

https://github.com/NixOS/nixpkgs/pull/80662
39 package marked as broken and skipped:
clang-sierraHack digitalbitbox gdata-sharp glibcCross linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 nix-linter octave-jit octoprint php72Packages-unit.php_excel php72Packages-unit.v8 php72Packages-unit.v8js php72Packages.php_excel php72Packages.v8 php72Packages.v8js php73Packages-unit.php_excel php73Packages-unit.v8 php73Packages.php_excel php73Packages.v8 php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages-unit.v8 php74Packages.couchbase php74Packages.pcs php74Packages.php_excel php74Packages.v8 python37Packages.pyblock python38Packages.libselinux python38Packages.notify python38Packages.poezio python38Packages.qiskit-ibmq-provider

1 package failed to build:
python38Packages.qiskit-aer

1 package built:
python37Packages.qiskit-aer

@jonringer jonringer merged commit 1b87322 into NixOS:master Mar 27, 2020
@drewrisinger drewrisinger deleted the dr-pr-python-qiskit-aer branch March 27, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants