nodePackages: netlify-cli init at 2.59.1 #80770
Conversation
matthuszagh
changed the title
|
I've updated this to fix merge conflicts. |
|
I tested this on NixOS and deployed a website with it without any problems. I think it might also make sense to add an entry to the top-level package set too. |
|
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
|
@prusnak I've updated this to use the new scheme. Added it to @utdemir in regard to adding a top-level package, this is the only node package I've contributed, so I'll defer to someone who's more familiar with nixpkgs and node packages. |
|
I do not know who to ping, but it'd be good to have this package in nixpkgs. It looks like it gets a merge conflict on |
|
@calbrecht I'm not sure if you're the right person to ping for a review here. Please excuse me if not. If you would be willing to provide a review, let me know and I'll fix the merge conflicts before you review (node-packages.nix is changed frequently so it doesn't make sense for me to try to keep this up-to-date before it's reviewed). Thanks! |
|
I've gone ahead and resolved the conflicts. |
|
@matthuszagh, lgtm 👌 Thanks. |
|
@globin, would you be willing to review this PR? If so, let me know and I'll resolve the merge conflicts. Thanks! |
|
It would be nice to merge this. |
|
@mrkkrp agreed. Unfortunately, I'm not sure who the right person to contact for that is. If you do know, mind notifying them? When someone with merge rights agrees to review this, I'll go ahead and resolve the merge conflicts. |
|
@infinisil would you be willing to review this PR? I noticed you merged |
|
Looks good to me, I can merge it if you re-update the node packages. Feel free to ping me when done :) |
matthuszagh
force-pushed
the
netlify-cli
branch
from
a7ac3e4
to
3430e91
Compare
|
Thanks so much @infinisil! I've fixed the merge conflicts. One remaining question: should I add a top-level package for this, or just leave it as is? |
matthuszagh
changed the title
|
Since this is not really a node package but only happens to be written with node, it would make sense to add a top-level package. |
matthuszagh
force-pushed
the
netlify-cli
branch
from
3430e91
to
5089fbf
Compare
|
@infinisil done. |
Motivation for this change
Adds the netlify-cli tool. Used generate.sh to create the nix build expressions, so this also updates other packages.
Things done
Added netlify-cli to node-packages-v10.json and then ran
./generate.sh.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)