Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-query-tree-viewer: init at 0.2.0 #80771

Merged
merged 1 commit into from Feb 22, 2020
Merged

nix-query-tree-viewer: init at 0.2.0 #80771

merged 1 commit into from Feb 22, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Feb 22, 2020 •
edited

Motivation for this change

Adds nix-query-tree-viewer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/announcing-nix-query-tree-viewer-gui-viewer-for-the-output-of-nix-store-query-tree/5980/2

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build nix-query-tree-viewer

jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
gui launches fine

[4 built, 106 copied (1027.7 MiB), 277.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80771
1 package built:
nix-query-tree-viewer

@cdepillabout cdepillabout merged commit d222dc2 into NixOS:master Feb 22, 2020
@cdepillabout cdepillabout deleted the add-nix-query-tree-viewer branch February 22, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @nixos-discourse @jonringer