Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: do not delete runtime plugins from package #80768

Merged
merged 1 commit into from Feb 25, 2020
Merged

mariadb: do not delete runtime plugins from package #80768

merged 1 commit into from Feb 25, 2020

Conversation

aanderse
Copy link
Member

Motivation for this change

I need dialog.so available to my mysql binary. I don't believe these .so files should be deleted because they are (all?) used by the mysql binary itself, not just something you would link against in a .dev output.

Here is the current problem, which this PR fixes:

[nix-shell:~]$ mysql --enable-ssl -h $HOST -u $USER -p
Enter password: 
ERROR 1045 (28000): Plugin dialog could not be loaded: /nix/store/jb0xzlcvk4b927j40424yx8775x4wn2s-mariadb-client-10.3.18//nix/store/jb0xzlcvk4b927j40424yx8775x4wn2s-mariadb-client-10.3.18/lib/mysql/plugin/dialog.so: cannot open shared object file: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice February 22, 2020 01:45
Izorkin
Izorkin approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@Izorkin Izorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for found this error.

@Mic92 Mic92 merged commit 5b732a1 into NixOS:master Feb 25, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 25, 2020

backported in 7161eb2

@aanderse aanderse deleted the mysql-dialog branch February 25, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izorkin Izorkin Izorkin approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Mic92 @Izorkin