Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snmp_exporter: 0.15.0 -> 0.17.0 #80649

Merged
merged 1 commit into from Feb 28, 2020
Merged

snmp_exporter: 0.15.0 -> 0.17.0 #80649

merged 1 commit into from Feb 28, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 20, 2020 •
edited

Motivation for this change

https://github.com/prometheus/snmp_exporter/releases/tag/v0.16.1
https://github.com/prometheus/snmp_exporter/releases/tag/v0.17.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from ehmry and WilliButz February 20, 2020 16:19
@WilliButz WilliButz merged commit e97dfe7 into NixOS:master Feb 28, 2020
@Frostman Frostman deleted the snmp_exporter-0.17.0 branch February 28, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @ehmry @WilliButz