Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerdfonts: fix build on MacOS #80690

Closed
wants to merge 2 commits into from
Closed

nerdfonts: fix build on MacOS #80690

wants to merge 2 commits into from

Conversation

uosis
Copy link
Contributor

@uosis uosis commented Feb 21, 2020

Motivation for this change

Nerdfonts does not build on MacOS due to incomplete patch script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Feb 21, 2020
@ofborg ofborg bot requested a review from NeQuissimus February 21, 2020 09:32
@alyssais
Copy link
Member

alyssais commented Apr 2, 2020

@GrahamcOfBorg build nerdfonts

@doronbehar doronbehar mentioned this pull request Apr 9, 2020
Merged
15 tasks
@uosis
Copy link
Contributor Author

uosis commented Apr 10, 2020

This is superseded by #84858 and can be closed if #84858 is merged.

@uosis
Copy link
Contributor Author

uosis commented Apr 10, 2020

#84858 is now merged so this is no longer needed.

@uosis uosis closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uosis @alyssais @NeQuissimus @Janik-Haag