@worldofpeace

Could we configure cursor themes for gtk as well?
I believe it's just another key/s in gtkrc.

Done, thanks!

@worldofpeace @jtojnar merge please?

@worldofpeace @jtojnar ping

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/configuring-system-wide-gtk-settings/5689/2

@gnidorah Could you expand the manual chapter "GTK/Qt themes" with a mention to this module and an example?

@rnhmjoj Done, thank you!

@rnhmjoj Thank you! arc-kde doesn't provide native qt style, instead it provides settings for 3rd party theme engine (kvantum)

doesn't provide native qt style

I figured it was different somehow, that explains it.

@rnhmjoj Thank you!

Thank you

👎 I feel like at least @jtojnar @ttuegel and myself should have approved on this before it was merged. I even expressed that to @gnidorah. With release management I've had almost no time to look at these things, which I'm sorry about. I probably should have at least mentioned that here also for everyone to see, instead of the mentions I made on IRC.

IMHO this has waited long enough, I hoped it would be in 20.03 already. Let's merge it.

As mentioned, it may look like it has waited and received improvements off feedback, but there really hasn't been much.

👎 I feel like at least @jtojnar @ttuegel and myself should have approved on this before it was merged. I even expressed that to @gnidorah.

I'm sorry. I saw the changes you requested were completed and @gnidorah had to fix conflicts several times so I thought it would be better to merge it now.

-1 I feel like at least @jtojnar @ttuegel and myself should have approved on this before it was merged. I even expressed that to @gnidorah.

I'm sorry. I saw the changes you requested were completed and @gnidorah had to fix conflicts several times so I thought it would be better to merge it now.

Indeed, it's sad for something like this to go unnoticed.

#80854. Could you open another PR for this? I will review it.
And you should also request review of @jtojnar, and @ttuegel on the qt module.
I'd for sure like to see @infinisil ✔️ on it since it's a new module, maybe we can make use of NixOS/rfcs#42.

It would also help, though I think you'd have to rewrite your history 😦, if the gtk module and the qt module weren't in the same PR. It just makes it easier to review, because they don't depend on each other.

Is there any way to override theme colors declaratively? I'd like to replace some colors with custom ones I have defined to be used throughout my configuration in variables

Hm, that only sets the the gtk theme, if I'm not mistaken. I was referring to changing the individual colors. For now I ended up doing it like this: https://github.com/pinpox/nixos-home/blob/1cefe28c72930a0aed41c20d254ad4d193a3fa37/gtk.nix#L11
Maybe someone knows a simpler solution?

@pinpox That looks quite nice. Under which license is your configuration? I'd like to include a setup like yours in my gtk.nix file but need it to be compatible with MIT.

@rycee Sure thing, go ahead. I have added MIT to the files, let me know if you have any questions

@pinpox Thanks, I've added it now.