Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p11-kit: 0.23.19 -> 0.23.20 #80698

Merged
merged 1 commit into from Feb 22, 2020
Merged

p11-kit: 0.23.19 -> 0.23.20 #80698

merged 1 commit into from Feb 22, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Feb 21, 2020 •
edited

Motivation for this change

Small bug fix release. Fixes a bunch of flatpak issues (eg. no playback
on spotify): p11-glue/p11-kit#275

news: https://github.com/p11-glue/p11-kit/releases/tag/0.23.20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
p11-kit: 0.23.19 -> 0.23.20
bbbb49c 
Small bug fix release. Fixes a bunch of flatpak issues (eg. no playback
on spotify).

news: https://github.com/p11-glue/p11-kit/releases/tag/0.23.20
@hedning hedning added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 21, 2020
@hedning hedning added this to WIP in Staging via automation Feb 21, 2020
@hedning hedning moved this from WIP to Ready in Staging Feb 21, 2020
@xvello
Copy link
Contributor

xvello commented Feb 22, 2020

For reference, this bug also impact online features of the flatpak version of steam, see flathub/com.valvesoftware.Steam#526

[0222/110531.254631:ERROR:cert_verify_proc_nss.cc(969)] CERT_PKIXVerifyCert for store.steampowered.com failed err=-8179
[0222/110531.255073:ERROR:ssl_client_socket_impl.cc(941)] handshake failed; returned -1, SSL error code 1, net_error -202

@hedning hedning merged commit 00ac5d8 into NixOS:staging Feb 22, 2020
Staging automation moved this from Ready to Done Feb 22, 2020
@hedning
Copy link
Contributor Author

hedning commented Feb 22, 2020

Lets get it into the next staging-next :)

@hedning hedning deleted the p11-kit-0.23.20 branch February 23, 2020 11:10
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/flatpak-error-the-name-org-freedesktop-accounts-was-not-provided-by-any-service-file/6000/10

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/flatpak-error-the-name-org-freedesktop-accounts-was-not-provided-by-any-service-file/6000/12

This was referenced Feb 26, 2020
Merged
Closed
@pio2398
Copy link
Contributor

pio2398 commented Mar 11, 2020

When we can expect this fix in 20.03? Because I still have this problem in 20.03.

@hedning
Copy link
Contributor Author

hedning commented Mar 11, 2020

Hmm, looking at the git logs, it should have landed in 20.03 already.

@pio2398
Copy link
Contributor

pio2398 commented Mar 12, 2020

I am have this channel: nixos https://nixos.org/channels/nixos-20.03 and still problem with Flatpak Steam. Should I open issue?
Error from Steam:

[0312/061900.469555:ERROR:ssl_client_socket_impl.cc(935)] handshake failed; returned -1, SSL error code 1, net_error -202

@hedning
Copy link
Contributor Author

hedning commented Mar 12, 2020

Right, according to the git log you should have the p11-kit update. So that's a bit strange. Might be worth checking out upstreams (p11-kit and flatpak) issue tracker and see if it's still an issue.

@pio2398 pio2398 mentioned this pull request Mar 12, 2020
Closed
@pio2398
Copy link
Contributor

pio2398 commented Mar 12, 2020

I opened bug report: #82422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @xvello @nixos-discourse @pio2398