Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentencepiece: set platforms to unix to support Darwin #80734

Merged
merged 1 commit into from Feb 22, 2020
Merged

sentencepiece: set platforms to unix to support Darwin #80734

merged 1 commit into from Feb 22, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change
  • The sentencepiece library builds fine on Darwin as well.
  • Remove superfluous enableParallelBuilding = true.
  • Make the value of homepage a string.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
sentencepiece: set platforms to unix to support Darwin
1a71e2c 
- The sentencepiece library builds fine on Darwin as well.
- Remove superfluous `enableParallelBuilding = true`.
- Make the value of homepage a string.
@jonringer
Copy link
Contributor

@GrahamcOfBorg build sentencepiece

@jonringer jonringer merged commit 9bab3b5 into NixOS:master Feb 22, 2020
@danieldk danieldk deleted the sentencepiece-darwin branch February 22, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer