Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] maven: make jdk overridable #80735

Merged
merged 1 commit into from Feb 27, 2020
Merged

[20.03] maven: make jdk overridable #80735

merged 1 commit into from Feb 27, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 21, 2020 •
edited

Motivation for this change

Backport of #80728, since it is a bug fix and the current behaviour is very confusing for users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
maven: make jdk overridable
b56f8c3 
This makes it possible to use maven with different (newer) jdks.

Fixes NixOS#75630

(cherry picked from commit 0141cfe)
@timokau timokau merged commit 9896034 into NixOS:release-20.03 Feb 27, 2020
@timokau timokau deleted the maven-jdk-overridable-20.09 branch February 27, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau