Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechatScripts.weechat-matrix: enable on darwin #80712

Merged
merged 1 commit into from Feb 21, 2020
Merged

weechatScripts.weechat-matrix: enable on darwin #80712

merged 1 commit into from Feb 21, 2020

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Feb 21, 2020 •
edited

Motivation for this change

According to @Feliix42 this works fine on Mac.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 21, 2020
tilpner
tilpner approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@tilpner tilpner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to test this, but it's fairly harmless to change. I don't remember why I initially set it to linux-only.

@bennofs bennofs merged commit 4194494 into NixOS:master Feb 21, 2020
@bennofs bennofs deleted the weechat-matrix-darwin branch February 21, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tilpner tilpner tilpner approved these changes

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennofs @tilpner @emilazy