Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.slackclient: 1.2.1 -> 2.5.0 #80755

Merged
merged 3 commits into from Feb 29, 2020
Merged

python.pkgs.slackclient: 1.2.1 -> 2.5.0 #80755

merged 3 commits into from Feb 29, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 21, 2020

This bumps slackclient to the latest PyPi release, and uses
pytestCheckHook to run pytest tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

JeffLabonte
JeffLabonte suggested changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds with Python 3.7 on NixOS. Python 2.7 fails

JeffLabonte
JeffLabonte suggested changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't build in python 2.7, since it

pkgs/development/python-modules/slackclient/default.nix Show resolved Hide resolved
pkgs/development/python-modules/slackclient/default.nix Show resolved Hide resolved
pkgs/development/python-modules/slackclient/default.nix Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor Author

flokli commented Feb 24, 2020

@JeffLabonte Thanks for the review! I adressed the comments, PTAL.

@JeffLabonte
Copy link
Contributor

I am wondering if the python in python-slackclient is necessary. I mean you already have python3.7 or python3.8 to add already. Also it is already in python-module, so I believe that it is one too many repetition for me.

What do you think @flokli?

jonringer
jonringer reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression in errbot

[2 built (1 failed), 17 copied (7.6 MiB), 2.1 MiB DL]
error: build of '/nix/store/0446y6a7q6x3g85la0anjjj54arv14jz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80755
1 package failed to build:
errbot

1 package built:
python37Packages.slackclient

@flokli
Copy link
Contributor Author

flokli commented Feb 25, 2020

slackclient v2 support in errbot seems to be blocked on errbotio/errbot#1367.

@jonringer
Copy link
Contributor

since errbot is an application, do you mind pinning the version similar to aws-sam-cli

@flokli
Copy link
Contributor Author

flokli commented Feb 28, 2020

@jonringer I pinned errbots version similar to how it's already done with markdown there - PTAL.

@ofborg ofborg bot requested review from fpletz and globin February 28, 2020 19:24
jonringer
jonringer reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/applications/networking/errbot/default.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the slackclient branch 2 times, most recently from 43deafe to 01f9faf Compare February 28, 2020 21:32
@flokli
Copy link
Contributor Author

flokli commented Feb 28, 2020

I don't really get why eval fails here, seems to be unrelated.

@jonringer
Copy link
Contributor

seeing as the latest 15 or so PRs are affected by this, I don't think this was your doing

@jonringer
Copy link
Contributor

I formalized a ticket #81325

@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

@GrahamcOfBorg eval

@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

@GrahamcOfBorg build python3.pkgs.slackclient errbot

@flokli
errbot: freeze slackclient at 1.2.1
7977811 
errbot requires slackclient 1.x, see errbotio/errbot#1367
latest 1.x release would be 1.3.2, but it requires an older websocket_client than the one in nixpkgs
so let's just vendor the known-working version until they've migrated to 2.x.
@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

@GrahamcOfBorg build python3.pkgs.slackclient errbot

@jonringer
Copy link
Contributor

looks like this is a regression, errbot.darwin builds on hydra https://hydra.nixos.org/build/113402669

@jonringer
Copy link
Contributor

@GrahamcOfBorg build errbot

1 similar comment
@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

@GrahamcOfBorg build errbot

@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

@jonringer I couldn't see how errbot could have regressed - we still ship the same dependencies afterwards.

Digging a bit more trough hydra, this seems to be flaky on darwin already: https://hydra.nixos.org/build/113098164/nixlog/1

I could mark it as broken for darwin, and add a comment explaining the kind of flakyness.

@flokli
errbot: disable for darwin
53555e5 
At least tests seem to be flaky there.
@flokli
Copy link
Contributor Author

flokli commented Feb 29, 2020

Pushed a commit doing that. Feel free to merge :-)

@jonringer
Copy link
Contributor

nah I'm fine with that. It's unfortunate that flaky tests exist, and on hardware most people don't have.

@jonringer
Copy link
Contributor

that being said, I have no motivation to ever get another mac

@jonringer jonringer merged commit ba27e63 into NixOS:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@JeffLabonte JeffLabonte JeffLabonte requested changes

@FRidh FRidh Awaiting requested review from FRidh

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @JeffLabonte @jonringer