Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trv: remove at 0.1.3 #80654

Merged
merged 5 commits into from Feb 28, 2020
Merged

trv: remove at 0.1.3 #80654

merged 5 commits into from Feb 28, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 20, 2020

Motivation for this change

This software has not been maintained for years and won’t build with recent versions of OCaml. Maintaining its legacy dependencies becomes a burden.

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Feb 25, 2020

In fact, cohttp_p4 has been broken by the recent update of glibc (#66528). This might be related to the change of makedev described in the release notes: https://www.sourceware.org/ml/libc-alpha/2018-08/msg00003.html

So this removal “fixes” that failure.

@vbgl vbgl merged commit 5c274c6 into NixOS:master Feb 28, 2020
@vbgl vbgl deleted the remove-trv branch February 28, 2020 20:24
@vbgl vbgl mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants