Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bear: Use python3 by default #80753

Merged
merged 1 commit into from Mar 26, 2020
Merged

bear: Use python3 by default #80753

merged 1 commit into from Mar 26, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 21, 2020 •
edited

Motivation for this change

Deprecate Python2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @babariviere

FRidh
FRidh requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the function parameter to python3 instead of having the change in all-packages.nix.

@ofborg ofborg bot requested a review from babariviere February 21, 2020 22:57
babariviere
babariviere approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no issue so far 👍

@aanderse
Copy link
Member

(triage) Given successful testing by both @doronbehar and @babariviere is everyone agreeing to merge?

@FRidh FRidh merged commit 7f2fc68 into NixOS:master Mar 26, 2020
@doronbehar doronbehar deleted the improve-bear branch March 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@babariviere babariviere babariviere approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @aanderse @FRidh @babariviere