Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abcde: use python3 eyeD3 #80752

Merged
merged 1 commit into from Mar 31, 2020
Merged

abcde: use python3 eyeD3 #80752

merged 1 commit into from Mar 31, 2020

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Deprecate Python2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @gebner.

@@ -18119,7 +18119,7 @@ in
aacgain = callPackage ../applications/audio/aacgain { };

abcde = callPackage ../applications/audio/abcde {
inherit (pythonPackages) eyeD3;
inherit (python3Packages) eyeD3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If eyeD3 is used only as application, then it should not be in python-packages.nix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it seems like a python module as well: https://eyed3.readthedocs.io/en/latest/modules.html

I think people may want to use it that way and expect to find it in pythonPackages.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timokau timokau merged commit 3bd7fc2 into NixOS:master Mar 31, 2020
@doronbehar doronbehar deleted the improve-abcde branch March 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants