patroni: init at 1.6.4 #80696
Merged
patroni: init at 1.6.4 #80696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
reviewed
Feb 23, 2020
pkgs/servers/sql/patroni/default.nix
Outdated
| preCheck = "export HOME=$(mktemp -d)"; | ||
|
|
||
| meta = with lib; { | ||
| homepage = https://patroni.readthedocs.io/en/latest/; |
There was a problem hiding this comment.
Suggested change
| homepage = https://patroni.readthedocs.io/en/latest/; | |
| homepage = "https://patroni.readthedocs.io/en/latest/"; |
| ydiff | ||
| ]; | ||
|
|
||
| preCheck = "export HOME=$(mktemp -d)"; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
pkgs/servers/sql/patroni/default.nix
Outdated
| }; | ||
|
|
||
| postPatch = '' | ||
| # cdiff renamed to ydiff; remove when patroni source reflects this. |
There was a problem hiding this comment.
Please put the comments outside the hook.
pkgs/servers/sql/patroni/default.nix
Outdated
| name = "patroni-${version}"; | ||
| version = "1.6.4"; | ||
|
|
||
| src = fetchurl { |
pkgs/servers/sql/patroni/default.nix
Outdated
| { lib, pythonPackages, fetchurl }: | ||
|
|
||
| pythonPackages.buildPythonApplication rec { | ||
| name = "patroni-${version}"; |
There was a problem hiding this comment.
The name attr will be applied automatically.
Suggested change
| name = "patroni-${version}"; | |
| pname = "patroni"; |
pkgs/servers/sql/patroni/default.nix
Outdated
| done | ||
| ''; | ||
|
|
||
| nativeBuildInputs = with pythonPackages; [ |
There was a problem hiding this comment.
Not a big deal, but I'd use checkInputs instead:
Suggested change
| nativeBuildInputs = with pythonPackages; [ | |
| checkInputs = with pythonPackages; [ |
invokesus
force-pushed
the
contrib/patroni
branch
from
fd55d09
to
e6c42d3
Compare
|
Thanks for reviewing. I amended and force-pushed. :) |
doronbehar
approved these changes
Feb 25, 2020
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Feb 26, 2020
patroni: init at 1.6.4 (cherry picked from commit b6f8e00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)