Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb-connector-c: add mysqlclient.pc pkgconfig symlink #80756

Merged
merged 1 commit into from Feb 25, 2020
Merged

mariadb-connector-c: add mysqlclient.pc pkgconfig symlink #80756

merged 1 commit into from Feb 25, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Feb 21, 2020

Motivation for this change

Some projects, like the mysqlclient-sys rust crate, use pkg-config to locate the mysqlclient library.

The mariadb-connector-c package only provides compatibility links for the mysql libs and includes. Adding the mysqlclient.pc link increases the compatibility with the build expecting the alternative name.

This fixes the currently failing build of bitwarden_rs-mysql in master and release-20.03.

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @globin

@ofborg ofborg bot requested a review from globin February 21, 2020 23:29
@Izorkin
Copy link
Contributor

Izorkin commented Feb 23, 2020

сс @aanderse @Mic92

@Mic92 Mic92 merged commit b93ef3b into NixOS:staging Feb 25, 2020
@Mic92 Mic92 added this to the 20.03 milestone Feb 25, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 25, 2020

Please also cherry-pick this into staging-20.03 as a PR.

@B4dM4n B4dM4n mentioned this pull request Feb 25, 2020
Merged
10 tasks
@B4dM4n B4dM4n deleted the mariadb-pkgconfig-link branch February 25, 2020 19:24
@Ma27 Ma27 mentioned this pull request Mar 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @Izorkin @Mic92