Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: Fix build for glibc 2.30 #80706

Merged
merged 1 commit into from Feb 21, 2020
Merged

swift: Fix build for glibc 2.30 #80706

merged 1 commit into from Feb 21, 2020

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Feb 21, 2020

Motivation for this change

ZHF #80379, so needs backport

Was broken since #66528

Fixes for glibc 2.30 in apple/swift#27288 (well I think this is because of it, not sure, but I needed this to fix the build) and apple/swift-package-manager#2408

Ping @mroi

Things done
  • Tested this patch on the release-20.03 branch with a successful build of swift on NixOS

@mroi
Copy link
Contributor

mroi commented Feb 21, 2020

Patch works here. Looks very good to me.

@infinisil infinisil merged commit 7a56099 into NixOS:master Feb 21, 2020
@infinisil infinisil deleted the fix/swift branch February 21, 2020 16:22
@infinisil
Copy link
Member Author

Backported in 9c7b4a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants