Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ammonite: fix source reference to allow dynamic binding #80707

Merged
merged 1 commit into from Mar 7, 2020
Merged

ammonite: fix source reference to allow dynamic binding #80707

merged 1 commit into from Mar 7, 2020

Conversation

uosis
Copy link
Contributor

@uosis uosis commented Feb 21, 2020

Motivation for this change

Static binding makes it impossible to override source.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam merged commit c5e223e into NixOS:master Mar 7, 2020
@marsam
Copy link
Contributor

marsam commented Mar 7, 2020

Thanks!

@uosis uosis deleted the ammonite branch March 8, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants