Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: remove qdarkstyle<2.7 restriction #80731

Merged
merged 1 commit into from Feb 21, 2020
Merged

electrum: remove qdarkstyle<2.7 restriction #80731

merged 1 commit into from Feb 21, 2020

Conversation

emmanuelrosa
Copy link
Contributor

Motivation for this change

This change removes the qdarkstyle<2.7 from requirements.txt so that electrum can build with qdarkstyle-2.8

Closes #80621

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ehmry, joachifm and np February 21, 2020 14:24
@joachifm joachifm merged commit 477ccd0 into NixOS:master Feb 21, 2020
@emmanuelrosa emmanuelrosa deleted the electrum-qdarkstyle-fix branch February 27, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@joachifm joachifm Awaiting requested review from joachifm

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

electrum: No matching distribution found for qdarkstyle<2.7
2 participants
@emmanuelrosa @joachifm