Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-appservice-slack: 1.0.2 -> 1.1.0 #80730

Merged
merged 1 commit into from Mar 21, 2020
Merged

matrix-appservice-slack: 1.0.2 -> 1.1.0 #80730

merged 1 commit into from Mar 21, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Feb 21, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka kampka force-pushed the matrix-appservice-slack_1_1_0 branch from 4bcb323 to 78f527d Compare March 19, 2020 15:12
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/133

@kampka kampka force-pushed the matrix-appservice-slack_1_1_0 branch from 78f527d to 5980050 Compare March 21, 2020 09:07
@veprbl veprbl merged commit 66758bc into NixOS:master Mar 21, 2020
@veprbl
Copy link
Member

veprbl commented Mar 21, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @nixos-discourse @veprbl