Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.drop-down-terminal: v24 -> unstable-2020-03-25 #83623

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.drop-down-terminal: v24 -> unstable-2020-03-25 #83623

wants to merge 1 commit into from

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Mar 28, 2020 •
edited

Motivation for this change

Add support to gnome 3.36.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ericdallo
Copy link
Member Author

Support added here: zzrough/gs-extensions-drop-down-terminal#238

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 28, 2020
@ericdallo ericdallo force-pushed the update-gnome-drop-down-terminal branch from 35ec33c to 76c22cc Compare March 28, 2020 21:56
@worldofpeace
Copy link
Contributor

This will conflict with what is is staging 687254f

@worldofpeace
Copy link
Contributor

Could you redo your change for staging so it can be merged when gnome 3.36 merges to master?

@ericdallo
Copy link
Member Author

Sure @worldofpeace, so should I close this PR and re-open after gnome 3.36 merge?

@ericdallo
Copy link
Member Author

How can I open a PR to staging? Is a different branch?

@worldofpeace
Copy link
Contributor

Sure @worldofpeace, so should I close this PR and re-open after gnome 3.36 merge?

I merged it manually to staging-next for you 72e5b2d.
Thanks 👋

@worldofpeace
Copy link
Contributor

How can I open a PR to staging? Is a different branch?

You could have used git rebase --onto to change the base branch to staging-next, and then edited this PR to merge to staging-next.

@ericdallo
Copy link
Member Author

Nice, thank you for the tip!

@ericdallo ericdallo deleted the update-gnome-drop-down-terminal branch March 28, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericdallo @worldofpeace