Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hspec-core: Disable tests on i686. #83571

Merged
merged 1 commit into from Mar 28, 2020
Merged

haskellPackages.hspec-core: Disable tests on i686. #83571

merged 1 commit into from Mar 28, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 28, 2020 •
edited

Motivation for this change

The tests have x86_64 results hardcoded, see hspec/hspec#431.

Intended to backport to 20.03 for ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 self-assigned this Mar 28, 2020
@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

Backport is at #83572

@nh2 nh2 requested a review from peti March 28, 2020 03:09
@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

I've tested the build on nixos-unstable, not yet on the just-updated master which updates all GHCs.

@cdepillabout
Copy link
Member

@nh2 Could you change the base of this to the haskell-updates branch?

Once you do that, feel free to just go ahead and merge in.

@nh2 nh2 changed the base branch from master to haskell-updates March 28, 2020 14:51
@nh2
haskellPackages.hspec-core: Disable tests on i686.
b5d100f 
The tests have x86_64 results hardcoded, see
hspec/hspec#431.
@nh2 nh2 force-pushed the hspec-core-disable-tests branch from 59e77d4 to b5d100f Compare March 28, 2020 15:13
@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

@nh2 Could you change the base of this to the haskell-updates branch?

Done.

@nh2 nh2 merged commit e85d09f into NixOS:haskell-updates Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

@peti peti Awaiting requested review from peti

Assignees

@nh2 nh2

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @cdepillabout @bhipple